This paper puts forward countermeasures to maximize the ecological benefits of agroforestry resources from the perspective of sustainable development of urban agroforestry resources. Taking the maximization of ecological benefits as the goal, the optimal allocation of agricultural and forestry resources is carried out. Based on the results of the optimal allocation of water resources, the planting structure of crops in the irrigation area is adjusted with the water allocation of irrigated crops as the constraint. The optimization model under the constraint of eco-efficiency objective was constructed based on the variational method and optimal control model, and the model was solved by the method of Pontryagin’s great value. After the model adjustment in this paper, the planting structure of crops in the irrigation area of city A was obviously optimized, and the planting area of potatoes accounted for the largest share of the planting area of all the crops in the irrigation area, which was about 40.61%, and the ecological benefits of potato crops were higher, which got the priority of the model, and at the same time, the model also reduced the planting area of the crops with low ecological benefits, and this reasonable allocation adjustment method satisfied the goal of maximizing ecological benefits.